Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitea 1.17 does not set PR description in commit detail when squash merging #20662

Closed
achikhv opened this issue Aug 4, 2022 · 2 comments
Closed
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail

Comments

@achikhv
Copy link

achikhv commented Aug 4, 2022

Description

This issue somehow relates to 20562.

Prior to 1.17 button "Create squash commit" opened a form with PR's description used as commit details. It was a handy little feature, and in 1.17 it has gone. Now commit details contains only "reviewed -on" field, and I must copy PR description and paste it to this field.

Is it possible to return this function?

Here is my test PR in try.gitea.io
https://try.gitea.io/achi/test/pulls/1

Thanks in advance.

Gitea Version

1.17.0+6-gbd2218e14

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Windows

How are you running Gitea?

Downloaded binaries here:
https://dl.gitea.io/gitea/1.17

Database

MSSQL

@wxiaoguang
Copy link
Contributor

It should have been fixed by

@wxiaoguang wxiaoguang added issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail and removed type/bug labels Aug 4, 2022
@achikhv
Copy link
Author

achikhv commented Aug 4, 2022

Thanks! Will check it out after build completes.

@achikhv achikhv closed this as completed Aug 4, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail
Projects
None yet
Development

No branches or pull requests

2 participants