Skip to content

Is it possible to not show all of the licenses ? #2239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
freedomtrain opened this issue Jul 31, 2017 · 16 comments
Closed

Is it possible to not show all of the licenses ? #2239

freedomtrain opened this issue Jul 31, 2017 · 16 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Comments

@freedomtrain
Copy link

Is it possible to not show all of the licenses ?

Thanks

@lafriks
Copy link
Member

lafriks commented Jul 31, 2017

I don't think so but you can set PREFERRED_LICENSES in app.ini that will be shown on top in select box

@lafriks lafriks added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jul 31, 2017
@lafriks lafriks added this to the 1.x.x milestone Jul 31, 2017
@freedomtrain
Copy link
Author

Thanks !!!!
Are the licenses entries hard coded ?
I deleted all of the licenses files that we do not want to show as an option and they still are showing up

@lafriks
Copy link
Member

lafriks commented Jul 31, 2017

They are compiled in binary. So to remove them you would have to recompile from source

@freedomtrain
Copy link
Author

freedomtrain commented Jul 31, 2017

Ah ha ......
Thanks !!!! Is there any documentation on how to recompile my current build from source ?

@sapk
Copy link
Member

sapk commented Aug 1, 2017

We have custom licenses, as stated in docs here, but the behavior is to extend the default one not replace them.

To compile the exact same build you need a golang env ready and follow https://docs.gitea.io/en-us/install-from-source/.
To know the commit/banch/version of binary use ./gitea -v of your current version. It will also display TAGS used to build the binary like sqlite or bindata

@sapk
Copy link
Member

sapk commented Aug 1, 2017

And I forget, if you find any bottleneck following the documentation, feel free to contribute to https://github.com/go-gitea/docs and ask question on Discord or here. 😉

@freedomtrain
Copy link
Author

I have have followed the instructions here https://docs.gitea.io/en-us/install-from-source/
The license that I have deleted are still showing up.

Are they in bindata ?

@sapk
Copy link
Member

sapk commented Aug 1, 2017

For context, bindata (more exacly go-bindata) is a program that convert file in go source code accessible like a filesystem.
Generated code should be under module/options. try to do a make clean, remove file under options/license that you don't want, and do make generate build with your tags.
You could also try without bindata tag but you will need to keep around static file like /templates or /public to work.

@lafriks lafriks reopened this Aug 4, 2017
@lafriks
Copy link
Member

lafriks commented Aug 4, 2017

As a feature this should be implemented in the future to be able manage licenses

@sapk
Copy link
Member

sapk commented Aug 4, 2017

One easy way could be to not use default licence if custom/licenses are used ? or add an option to not use default.

@BjoernAkAManf
Copy link
Contributor

I was looking for something similar. How about a special file inside the license (or other overriding) folder like .INCLUDE or .EXCLUDE to specify included or exclude licenses respectively? It would be a shame to maintain a separate set of licenses just to remove some defaults.

@strk
Copy link
Member

strk commented Dec 19, 2017

Pull request adding documentation for PREFERRED_LICENSES: #3230

@stale
Copy link

stale bot commented Feb 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 10, 2019
@lunny lunny added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels Feb 11, 2019
@lunny lunny removed this from the 1.x.x milestone Mar 20, 2023
@wolftune
Copy link

I think it would be preferable to indeed have a shorter list. At the least, showing all versions of licenses (such as even CC-BY 1.0 and 2.0 and 2.5 etc) is really noisy. If someone is actually going to use obscure or outdated licensing or is importing an old repo, they can do that without using the dropdown menu in creating new repos.

I would urge that a shorter list be used in general even for the relatively complete set. And it would be nicest to have a default of showing only the PREFERRED_LICENSES

@lunny
Copy link
Member

lunny commented Jan 15, 2024

I think this could be closed and we can track #28661.

@lunny lunny closed this as completed Jan 15, 2024
Copy link

github-actions bot commented Mar 1, 2024

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

No branches or pull requests

7 participants