Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw ISO date time displayed instead of relative time #24122

Closed
bagasme opened this issue Apr 14, 2023 · 6 comments
Closed

Raw ISO date time displayed instead of relative time #24122

bagasme opened this issue Apr 14, 2023 · 6 comments
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail topic/ui Change the appearance of the Gitea UI

Comments

@bagasme
Copy link
Contributor

bagasme commented Apr 14, 2023

Description

I built Gitea from source on Debian 11 using Go 1.20.3 and Node v18.13.0 (npm 8.19.3). Yesterday I built commit 4299c3b. Before building, I wiped out node_modules directory (as it contains node artifacts). Then I built as usual and deployed to my Gitea instance on LXD container. Previous commit deployed to the instance before the rebuild was commit 57aab79. No app.ini changes between deployments.

The Gitea instance uses PostgreSQL 15.2 on another container.

When I logged in to the instance, I noticed that raw ISO 8601 date time format was displayed instead of usual relative time (e.g. 12 minutes ago) when I browse my repos and also on the dashboard.

I have tried reproducing on try.gitea.io but the issue doesn't occur (as it was deployed from commit 334c899) so either I have issues on my app.ini or this issue had been fixed in more recent commits than I deployed.

Here are gitea.log from my instance and sanitized config.

Screenshots

On the production

Recent Gitea repo push on the dashboard
Tree of internal site sources

On try.gitea.io

Testing repo tree
Recent testing repo push on the dashboard

Gitea Version

main (commit 4299c3b)

Can you reproduce the bug on the Gitea demo site?

No

Operating System

Ubuntu 22.04

Browser Version

Firefox Developer Edition (113.0.b2)

@bagasme bagasme added type/bug topic/ui Change the appearance of the Gitea UI labels Apr 14, 2023
@wxiaoguang
Copy link
Contributor

The relative-time is related to #23988 (which still has some open issues/PRs)

For the file list, I guess it's related to #24106 @yardenshoham

@yardenshoham
Copy link
Member

@bagasme does https://github.com/github/relative-time-element work in your browser? Does https://github.github.io/relative-time-element/examples/ render for you?

@wxiaoguang do we polyfill the JS.Intl APIs?

@yardenshoham
Copy link
Member

I was able to reproduce:
image

I did it by compiling webpack without @github/relative-time-element:
image

Please make sure you have that package in node_modules

@yardenshoham yardenshoham added issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail and removed type/bug labels Apr 14, 2023
@delvh
Copy link
Member

delvh commented Apr 14, 2023

Can this issue be closed then?

@yardenshoham
Copy link
Member

Let's make sure @bagasme fixed their issue

@bagasme
Copy link
Contributor Author

bagasme commented Apr 14, 2023

Issue fixed by checking node_modules to contain appropriate module as @yardenshoham said. Closing.

@bagasme bagasme closed this as completed Apr 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

No branches or pull requests

4 participants