Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 in 1.20.1 when branch name contains # #26088

Closed
dusatvoj opened this issue Jul 24, 2023 · 3 comments
Closed

404 in 1.20.1 when branch name contains # #26088

dusatvoj opened this issue Jul 24, 2023 · 3 comments
Labels
Milestone

Comments

@dusatvoj
Copy link

Description

I did an upgrade to gitea 1.20.1 (from 1.19.x) and now I'm facing the issue with WebUI - it's returning 404 when branch name contains #.

Link contains unescaped # ( ...branch#130... ) - it could cause the problem 🤔

It's pretty severe bug bcs we are using reference of issue in branch name, so almost every branch has # in it's name 🙈

Gitea Version

1.20.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Debian 11

How are you running Gitea?

Built from source, run by systemd, proxied by external nginx.

Database

PostgreSQL

@stuzer05
Copy link
Contributor

Same here, problem is still present on latest dev commit.

image
image

@silverwind
Copy link
Member

Should be fixed when #25875 is backported.

@lunny lunny added this to the 1.20.2 milestone Jul 25, 2023
@lunny
Copy link
Member

lunny commented Jul 25, 2023

Closed as #26103 merged.

@lunny lunny closed this as completed Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants