Skip to content

Inaccurate display of "Viewed" count in file diff when expanding files #26854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Menah3m opened this issue Sep 1, 2023 · 1 comment
Closed
Labels

Comments

@Menah3m
Copy link

Menah3m commented Sep 1, 2023

Description

I have observed a bug in Gitea's file diff feature regarding the display of "Viewed" count in the context of expanding files.

I have configured the "MAX_GIT_DIFF_LINES:200" and "MAX_GIT_DIFF_FILES:20" settings in app.ini . However, when I expand files in the diff view, the "Viewed" count appears to be inaccurately tracked. Specifically, clicking "View More" seems to reset the viewed count and sometimes even results in a negative count when unchecking previously viewed files.

Gitea Version

1.19.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

image

Git Version

1.8.3.1

Operating System

centos 7

How are you running Gitea?

it is being run from a helm chart.

Database

PostgreSQL

@delvh
Copy link
Member

delvh commented Sep 1, 2023

I think that bug was already fixed, please update to 1.20.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants