Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retargeting / stacking pull requests #28384

Closed
niekvanderkooy opened this issue Dec 7, 2023 · 1 comment
Closed

Retargeting / stacking pull requests #28384

niekvanderkooy opened this issue Dec 7, 2023 · 1 comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@niekvanderkooy
Copy link

Feature Description

I would like to suggest PR retargeting functionality. Meaning: If PR B targets branch A, and PR C targets branch (/PR) B, merging PR B into A would cause the target of PR C to automatically change from B to A.

See also the description on the same github functionality .

The use case is enabling a developer to split up a PR into more manageable pieces. Say we are developing a large piece of functionality with both back-end ( featureA ) and front-end ( featureB ) components. One could write the featureA , targeting a project's main branch. Once this functionality exists, a front-end developer could use this as a starting point for featureB. Targeting the project's main branch would not work, since this does not yet contain the (unreviewed) back-end functionality. And continuing in the back-end branch would create a larger PR than needed, making the review process more difficult.

My current workaround is that featureB branches from featureA, but targets main. However, this makes featureB impossible to review before featureA has been completely reviewed and merged, because otherwise the featureB PR will also contain the changes in featureA.

Would also solve #19190 (See this comment specifically, suggesting the same idea).

Screenshots

No response

@niekvanderkooy niekvanderkooy added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Dec 7, 2023
@niekvanderkooy
Copy link
Author

My apologies, I should have searched longer before submitting this issue.
Already covered by #18408 and #18478

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

1 participant