Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-emphasize signed commits #29641

Closed
silverwind opened this issue Mar 6, 2024 · 4 comments · Fixed by #31160
Closed

De-emphasize signed commits #29641

silverwind opened this issue Mar 6, 2024 · 4 comments · Fixed by #31160
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@silverwind
Copy link
Member

silverwind commented Mar 6, 2024 •
edited
Loading

I think the current UI gives too much attention to signed commits. Big green box on commit page, green box on commit hashes. Signing is important but not so important that we have to plaster the UI with these colors. I think a simple "verified" icon should be enough when viewing the commit detail page, and no indicator at all on commit hashes.

image Screenshot 2024-03-06 at 22 50 58
@silverwind silverwind added type/proposal The new feature has not been accepted yet but needs to be discussed first. issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail labels Mar 6, 2024
@silverwind silverwind mentioned this issue Mar 14, 2024
Open
@silverwind silverwind added proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. and removed issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail labels Mar 14, 2024
This was referenced Mar 17, 2024
Closed
Closed
@silverwind silverwind mentioned this issue Apr 1, 2024
Closed
@silverwind silverwind mentioned this issue Apr 17, 2024
Closed
@BlenderDefender
Copy link
Contributor

For comparison: This is, how it looks like on GitHub:
Commit list:
grafik

Commit details:
grafik

@BlenderDefender
Copy link
Contributor

Could look something like this:
image
image

@BlenderDefender
Copy link
Contributor

Other layouts where this badge would appear:
grafik
grafik
grafik

@BlenderDefender
Copy link
Contributor

Clicking the badge would trigger a modal:
grafik
grafik

@BlenderDefender BlenderDefender mentioned this issue May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

De-emphasize signed commits BlenderDefender/gitea
2 participants
@silverwind @BlenderDefender