Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple review comments on the same line #32290

Open
jpraet opened this issue Oct 18, 2024 · 2 comments
Open

Allow multiple review comments on the same line #32290

jpraet opened this issue Oct 18, 2024 · 2 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@jpraet
Copy link
Member

jpraet commented Oct 18, 2024

Feature Description

It would be useful if we could add multiple review comments on the same line.
Currently you can only reply to an existing comment/conversation on that line, but not start a new one.

Screenshots

On GitHub it is possible:

image
@jpraet jpraet added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Oct 18, 2024
@yp05327

This comment was marked as outdated.

Sign in to view
@lunny
Copy link
Member

lunny commented Nov 5, 2024

Duplicated #4898 And see #32384

It's not the same as #4898. That issue would like to comment on a special commit but not pull request commit. This issue would like the comments on the same line can be splitter as multiple ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lunny @jpraet @yp05327