Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE/eslint doesn't report un-imported $ as undefined any more #32982

Closed
wxiaoguang opened this issue Dec 25, 2024 · 0 comments · Fixed by #33002
Closed

IDE/eslint doesn't report un-imported $ as undefined any more #32982

wxiaoguang opened this issue Dec 25, 2024 · 0 comments · Fixed by #33002
Labels

Comments

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Dec 25, 2024

Maybe caused by a related dependency change by Update JS and PY dependencies (#32482) and/or some recent upgrades.

It seems that the eslint dependency is also broken.

cc @silverwind

# comment out the first `import $ from 'jquery';` line
#
# the commit before #32482
$ git checkout cad313e64f01146b34b66ed6aa1344d9002dfe6c
$ npm i && npx eslint web_src/js/features/repo-issue-content.ts 
/Users/xiaoguang/work/gitea/web_src/js/features/repo-issue-content.ts
   14:17  error  '$' is not defined  no-undef

$ git checkout main
$ npm i && npx eslint web_src/js/features/repo-issue-content.ts
(no eslint error)
(but there are other npm warnings)

Before:

image

After:

image

@wxiaoguang wxiaoguang changed the title IDE doesn't report un-imported $ as undefined any more IDE/eslint doesn't report un-imported $ as undefined any more Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant