Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin tip cover the dropdown icon #32991

Closed
yp05327 opened this issue Dec 26, 2024 · 5 comments · Fixed by #33015
Closed

Admin tip cover the dropdown icon #32991

yp05327 opened this issue Dec 26, 2024 · 5 comments · Fixed by #33015
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@yp05327
Copy link
Contributor

yp05327 commented Dec 26, 2024

Description

From : #32927
In my browser:
image
In the PR's description:
image

It seems that the admin tip cover the dropdown icon

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None

@kemzeb kemzeb added the topic/ui Change the appearance of the Gitea UI label Dec 26, 2024
@wxiaoguang
Copy link
Contributor

Try to make it smaller:

diff --git a/web_src/css/modules/navbar.css b/web_src/css/modules/navbar.css
index b5bc95b058..b60d25977d 100644
--- a/web_src/css/modules/navbar.css
+++ b/web_src/css/modules/navbar.css
@@ -103,11 +103,11 @@
 #navbar .ui.dropdown .navbar-profile-admin {
   display: block;
   position: absolute;
-  font-size: 10px;
+  font-size: 9px;
   font-weight: var(--font-weight-bold);
   color: var(--color-nav-bg);
   background: var(--color-primary);
-  padding: 2px 4px;
+  padding: 2px 3px;
   border-radius: 10px;
   top: -1px;
   left: 18px;

@yp05327
Copy link
Contributor Author

yp05327 commented Dec 27, 2024

Maybe an icon or a border is better?
If it is a word ‘admin’ here, in other languages it maybe very long?

@wxiaoguang
Copy link
Contributor

If it is a word ‘admin’ here, in other languages it maybe very long?

image

@yp05327
Copy link
Contributor Author

yp05327 commented Dec 27, 2024

Personally, I prefer using an icon like sparkle-fill or sparkles-fill or something else, not a const word. Of cause, it is acceptable adjusting the font size.

@wxiaoguang
Copy link
Contributor

I prefer using an icon like sparkle-fill or sparkles-fill or something

I didn't find a suitable icon to show that "the current user is an admin", if the icon's meaning is not clear, it would mislead & confuse users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants