Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy to Clipboard button is missing when SSH is enabled, HTTP is disabled. #3771

Closed
2 tasks done
awwong1 opened this issue Apr 9, 2018 · 3 comments · Fixed by #3773
Closed
2 tasks done

Copy to Clipboard button is missing when SSH is enabled, HTTP is disabled. #3771

awwong1 opened this issue Apr 9, 2018 · 3 comments · Fixed by #3773
Labels
type/bug
Milestone
1.4.1

Comments

@awwong1
Copy link

awwong1 commented Apr 9, 2018 •
edited
Loading

  • Gitea version (or commit ref): 1.4.0
  • Git version: 2.1.4
  • Operating system: Raspbian Linux raspberrypi 4.9.35-v7+ #1014 SMP Fri Jun 30 14:47:43 BST 2017 armv7l GNU/Linux
  • Database (use [x]):
    • MySQL
  • Can you reproduce the bug at https://try.gitea.io:
    • Not relevant

Description

Copy to Clipboard button is missing when SSH is enabled, HTTP is disabled.

This can be toggled by setting custom/conf/app.ini

[repository]
DISABLE_HTTP_GIT = false

DISABLE_HTTP_GIT = true #this should also show the copy to clipboard button

Expected fuctionality is Copy to Clipboard button stays no matter what this setting is.

Screenshots

When SSH and HTTPS are both enabled:
screen shot 2018-04-08 at 10 11 03 pm

When only SSH is enabled:
screen shot 2018-04-08 at 10 11 36 pm
@appleboy appleboy mentioned this issue Apr 9, 2018
Merged
@appleboy
Copy link
Member

appleboy commented Apr 9, 2018

fix in #3773

@lafriks lafriks modified the milestones: 1.5.0, 1.4.1 Apr 9, 2018
@lunny
Copy link
Member

lunny commented Apr 9, 2018

@appleboy please send a backport to v1.4.1

@appleboy
Copy link
Member

appleboy commented Apr 9, 2018

@lunny See #3774

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.4.1
Development

Successfully merging a pull request may close this issue.

fix: show Clipboard button if disable HTTP of git protocol appleboy/gitea
4 participants
@appleboy @lunny @lafriks @awwong1