-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown parsing incorrectly for video links #3845
Comments
This commit on my own gitea instance demonstrates that the link is parsed incorrectly. |
Just found out this bug, it's impractical to embed any video without fixing this, as shown a pic for the video is very helpful. |
@coolaj86 gitea 1.6.0 seems fixed this, I can click on the image then it jumps to youtube and starts playing. still, if you self-host the video, you need click on the image to see the video, then click on the video to play it, it would be nice if I can play the video with one click though |
Gitea version 1.4.0
Go version 1.1.0
This snippet in the README.md should create an image that links to the YouTube video:
Like this:
Instead it creates an
<a>
tag with an empty string that cannot be clicked on for the YouTube video and a second link to the picture, which links to the picture itself.Example:
https://git.coolaj86.com/coolaj86/greenlock-express.js/src/commit/dfabdd15dd04742a7af296b70ad84d674f956953/README.md
The text was updated successfully, but these errors were encountered: