Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit CommonMark support (with documented deviations) #4027

Closed
2 tasks done
lofidevops opened this issue May 23, 2018 · 4 comments · Fixed by #9533
Closed
2 tasks done

Explicit CommonMark support (with documented deviations) #4027

lofidevops opened this issue May 23, 2018 · 4 comments · Fixed by #9533

Comments

@lofidevops
Copy link

  • Gitea version (or commit ref): Any
  • Git version: N/A
  • Operating system: Any
  • Database (use [x]):
    • Any
  • Can you reproduce the bug at https://try.gitea.io:
    • Not relevant
  • Log gist: N/A

To support interoperability with other software (e.g. text editors), Gitea should explicitly support the CommonMark standard, and document any deviations from/extensions to the standard.

Depends on:

@lunny lunny added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label May 23, 2018
@tankerkiller125
Copy link

So far from what I can tell the deviations from CommonMark are basically the same ones the Github has. Notably, table support, automatic link detection without the <> @mentions support #ticketid support. Honestly, no service supports CommonMark to the exact spec. The CommonMark spec is extremely limiting in scope and some things have been made standard by Github or other services and everyone agrees that its the way its done even though its not in the spec. Tables is an excellent example of something that is not in the spec but everyone has agreed on a standard for.

@guybrush
Copy link

guybrush commented Jun 25, 2018

GFM is a strict superset of CommonMark.

try this on gitea and on github:

* a
  * b
    * c
  • on github the indentation of c will be 3
  • on gitea the indentation of c will be 2 (same as b)

this is only one issue, but for me the most annoying one

@westurner
Copy link

#### GitLab, Gitea
This has two trailing spaces..  
And so there's a newline/br here.

But here
there's no trailing space so there's no newline; just a space (' ')

#### GitHub
This lacks two trailing spaces
But GitHub still makes a newline/br

GitLab, Gitea

This has two trailing spaces..
And so there's a newline/br

GitHub

This lacks two trailing spaces
But GitHub still makes a newline/br

@lafriks
Copy link
Member

lafriks commented Dec 31, 2019

Please reopen if still not fixed

@lafriks lafriks removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Dec 31, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants