Keep database password from preseeded configuration file

[tarelda]

• Gitea version (or commit ref): fa3ceb6
• Git version: not relevant to the issue
• Operating system: alpine:latest
• Database (use [x]):
  • PostgreSQL
  • MySQL (MariaDB)
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist: Not relevant

Description

I created fat gitea docker container, which contains also all other required services. It is just the way that suits my deployment. Issue I bumped into is, that database password is automagically generated in entrypoint and correctly seeded into configuration file, but when using installer it just omits it.
My expected behaviour is that when I preseed password it has to be kept instead of zeroing it.
Can this be fixed or at least available with feature switch like --enable-preseeded-config ?

[bkcsoft]

If you seed your config-file you should set [security] INSTALL_LOCK = true to skip the /install step. If that is done the password should not be reseeded.

[tarelda]

This is not a solution, because it disables installer, which I explicitly want to avoid.
What is more, I can't come up with single reason, why installer doesn't keep password from config while reading all of the other settings.

[bkcsoft]

Before the installation, Gitea does not read the config file. Why would it, since it might not exist?

[tarelda]

@bkcsoft, it seems you are wrong
https://github.com/go-gitea/gitea/blob/master/routers/install.go

gitea/models/models.go

Line 133 in 85414d8

func LoadConfigs() {

gitea/modules/setting/setting.go

Line 675 in 85414d8

if com.IsFile(CustomConf) {

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[stale]

This issue has been automatically closed because of inactivity. You can re-open it if needed.

[lunny]

should be closed by #4284