Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the first word at WORK_IN_PROGRESS_PREFIXES starts with <, the hint is shown incorrectly #4705

Closed
InExtremaRes opened this issue Aug 14, 2018 · 3 comments · Fixed by #4709
Labels
Milestone

Comments

@InExtremaRes
Copy link

  • Gitea version (or commit ref): 03e558c
    (the rest are not relevant or difficult)

Description

Since #4529 a commit can be marked as WIP. The WIP prefix can be configured. We have marked our PR with a <WIP> prefix format since a while, so we put that as the default. I have this in my app.ini:

[repository.pull-request]
; List of prefixes used in Pull Request title to mark them as Work In Progress
WORK_IN_PROGRESS_PREFIXES=<WIP>,WIP:,[WIP]

It works pretty well, except for the hint text that doesn't show the prefix to use:

image

You can see the hint only says Start the title with, without the <WIP>. For reference, here is how is showed with default values:

image

After a little of experimentation, it seems the problem occurs any time the prefix start with a < character.

@JulienTant

@JulienTant
Copy link
Contributor

Ok i'm going to take a look at this, this probably needs some html escaping before printing. Thanks for reporting

@JulienTant
Copy link
Contributor

ICYMI @InExtremaRes I created a PR to fix the bug : #4709

@InExtremaRes
Copy link
Author

Yes. Thank you so much. I'm following the discussion there.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants