Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply button disappear on click in PR when language is spanish #5237

Closed
2 of 7 tasks
tonivj5 opened this issue Oct 31, 2018 · 5 comments
Closed
2 of 7 tasks

Reply button disappear on click in PR when language is spanish #5237

tonivj5 opened this issue Oct 31, 2018 · 5 comments

Comments

@tonivj5
Copy link
Contributor

tonivj5 commented Oct 31, 2018

Description

I think it's self-explanatory

Screenshots

  • Pre-clicked
    image
  • Post-clicked
    image
  • In another languages (Deutsch). It works
    image
  • However, in files changed I can click and reply 😆
    image
@Caballerog
Copy link

I have the same problem using the last docker image. I've used the english language which works.

@zeripath
Copy link
Contributor

zeripath commented Nov 6, 2018

OK I think that the locale-es_ES.ini file has a problem. There are likely other problems in that file too.

line 459:

...
issues.commented_at=`comentado <a href="#%s"> %s`</a>
...

is the cause of this issue. The backtick (`) before the </a> means that the <a href="..."> is never closed.

@techknowlogick
Copy link
Member

@zeripath thanks for digging deep into this issue. I was worried that it would've been something like that because why would it work for english and not other languages. This means that the linked PR won't work, and the fixes will need to be put into crowdin.

cc: @lafriks

@techknowlogick
Copy link
Member

Oh wait. PR still may work.

@lafriks
Copy link
Member

lafriks commented Nov 6, 2018

I have fixed Spanish translation in crowdin but #5239 fixes other problem I think

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants