Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Pull Requests history #5254

Closed
iddm opened this issue Nov 2, 2018 · 8 comments
Closed

Implement Pull Requests history #5254

iddm opened this issue Nov 2, 2018 · 8 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@iddm
Copy link
Contributor

iddm commented Nov 2, 2018

It would be nice to have history of changes in the pull requests as it is in gitlab, for example: if someone pushes commit with force, it would be nice to have diff of what was before this push, so, probably, we should store changes for that and notify user on each push event as in gitlab.

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Nov 2, 2018
@singalen
Copy link

Rebase and force-push is a natural workflow of PR that is not accepted immediately.
Of course, one could close one PR and open another one, but it would be much better to keep a history of PR and its reviews.

@lafriks
Copy link
Member

lafriks commented Jan 22, 2019

Do you have any suggestions on how to store it git repository?

@iddm
Copy link
Contributor Author

iddm commented Apr 19, 2019

@lafriks I am not sure I understand what you were saying.

@lafriks
Copy link
Member

lafriks commented Apr 23, 2019

I asked if anyone has ideas on how to store/get previous changes that have been removed from branch by force push

@iddm
Copy link
Contributor Author

iddm commented Apr 23, 2019

What about storing them in the gitea's database?

@singalen
Copy link

The question is about the record format, I believe.
I don't have the experience with git database format, but gerrit or gitlab formats should do.

Particularly, each PR version can be saved as a hidden branch; the comments to the commits would be stored the way they are now.
You may even want to reimplement gerrit's master feature: use or calculate a mapping between different versions of same commit across PR versions in Change-Id: field, and display a history of a commit.

@ghost
Copy link

ghost commented Aug 31, 2020

Actually I just discovered this issue. I think this is the same as the one I opened: #12604.

The related work in progress pull request is: #12665

@singalen
Copy link

Yay, thanks a ton!

@ghost ghost mentioned this issue Sep 10, 2020
@ghost ghost mentioned this issue Oct 26, 2020
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants