Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drone is not recognizing gitea release creation #5288

Closed
2 of 7 tasks
xoxys opened this issue Nov 7, 2018 · 11 comments
Closed
2 of 7 tasks

Drone is not recognizing gitea release creation #5288

xoxys opened this issue Nov 7, 2018 · 11 comments

Comments

@xoxys
Copy link
Contributor

xoxys commented Nov 7, 2018

  • Gitea version (or commit ref): 1.5.3
  • Git version:
  • Operating system: RHEL
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant

Description

As mentioned here and here for me, there seems to be some issues with gitea webhooks.

if i create a release from the gitea ui (creates also a tag in background), drone does not recognize it and is not running the pipeline.

If i instead push a tag from command line to remote repo, drone will run twice. One run for the push and one run for the tag... That duplicates the runtime. Is this the expected behavior?

@tboerger
Copy link
Member

tboerger commented Nov 7, 2018

If i instead push a tag from command line to remote repo, drone will run twice. One run for the push and one run for the tag... That duplicates the runtime. Is this the expected behavior?

This have been explained at harness/harness#2519 (comment), this is really the expected behavior.

@xoxys
Copy link
Contributor Author

xoxys commented Nov 7, 2018

@tboerger You say:

If you think this is the wrong behavior this is also something that needs to be changed within gitea.

So yes i am not sure if this is the correct behavior and asked to the gitea team also. I am not sure if it makes sense to run it twice in case of an git push tag. What is worng with this question?

@tboerger
Copy link
Member

tboerger commented Nov 7, 2018

So yes i am not sure if this is the correct behavior and asked to the gitea team also. I am not sure if it makes sense to run it twice in case of an git push tag. What is worng with this question?

You have pushed a commit that have not been on the server before and a tag at the same time. That's why 2 events are triggered. That's as explained by brad an expected behavior.

@zdk123
Copy link

zdk123 commented Dec 10, 2018

I am also interested in this issue, especially if this is the expected behavior:

if i create a release from the gitea ui (creates also a tag in background), drone does not recognize it and is not running the pipeline.

For a large repo, I'd like to trigger drone without having to clone the whole repo.

@xoxys
Copy link
Contributor Author

xoxys commented Dec 22, 2018

Tested the same szenario with cloud.drone.io and github and this setup do it right. If i create a release at github web drone runs a single task for the new tag. If i create a new tag at the command line and push these new tag drone runs only once also to handle the new tag. Sorry but i think there is an issue at drone or gitea site handling this szenario.

@tboerger
Copy link
Member

Have you checked within the webhooks page if gitea is sending a webhook if you create a tag via web ui? If it sends a webhook but no build starts even if the tags checkmark within drone is checked than it's a bug within drone. If no webhook gets sent it's a bug within gitea.

@xoxys
Copy link
Contributor Author

xoxys commented Dec 22, 2018

Ah thanks to pointing me in this direction. Will check this

@xoxys
Copy link
Contributor Author

xoxys commented Dec 24, 2018

So i test it and that is the result:
Gitea sends a webhook for a new release created over the web ui but the type is release and i am not sure if drone can handle that. If i add a taf from the command line and push gitea will send a create and a push event.
grafik

@tboerger
Copy link
Member

A release event isn't the same as a tag event, I don't think this is something that should be integrated by Drone, otherwise Drone will especially in combination with plugins like gitea-release build the same stuff twice. Gitea should also correctly trigger an event tag if the tag gets created via the webui by the release creation.

@stale
Copy link

stale bot commented Feb 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 22, 2019
@stale
Copy link

stale bot commented Mar 8, 2019

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed Mar 8, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants