Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow edits from maintainers in PR #717

Closed
rugk opened this issue Jan 22, 2017 · 3 comments
Closed

Allow edits from maintainers in PR #717

rugk opened this issue Jan 22, 2017 · 3 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone

Comments

@rugk
Copy link
Contributor

rugk commented Jan 22, 2017

It would be nice to introduce the same feature that GitHub now has:
prallowedits

As far as I understand it this allows maintainers of the main repo, where you submit a PR to, to push to your PR. So they can now improve your PR without having to wait that the creator of the PR fixes the issues.


upstream issue: gogs/gogs#3762


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@lunny lunny added this to the 1.x.x milestone Jan 22, 2017
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jan 22, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Feb 12, 2017

This might be a bit hard at the moment, since we now only map HasAccess(user, repo) and not HasAccess(user, repo, branch)... And we would have to check which branches are being pushed, which might lead to security issues 🙁

@stale
Copy link

stale bot commented Feb 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 17, 2019
@lunny lunny added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels Feb 17, 2019
@wxiaoguang
Copy link
Contributor

@lunny lunny modified the milestones: 1.x.x, 1.17.0 Apr 29, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

No branches or pull requests

4 participants