Skip to content

[Branch View] put all controll buttons in the same td and make them look similar #7606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6543 opened this issue Jul 24, 2019 · 9 comments
Closed
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI

Comments

@6543
Copy link
Member

6543 commented Jul 24, 2019

I think the current implementation takes away too much space from the important left-aligned column because having the buttons inside individual fixed columns introduces unnecessary spacing. I'd put all three buttons in the same td and make them look like this (remove compact class on the pull button):

Then right-align the diffstat and let the leftmost column take the remaining space.

Originally posted by @silverwind in #7520 (comment)

@6543
Copy link
Member Author

6543 commented Jul 24, 2019

blocked by #7602 #7604

@silverwind
Copy link
Member

Not sure if that split-up was really necessary. Those two PRs conflict each other unfortunately. Maybe wait till #7602 is merged and then do the remaining changes in #7604 to achieve the equivalent of that screenshot?

@6543
Copy link
Member Author

6543 commented Jul 25, 2019

i thought the contributor guidline tells me that if i like to get changes merged quik i should make smal PRs wich a single wish/topic

@6543
Copy link
Member Author

6543 commented Jul 25, 2019

i cann still klose the smal PRs and contribute to the big one?

@silverwind
Copy link
Member

Yes, small changes get merged faster but your old one wasn't really that big. Anyways, I'd suggest sticking to the plan above. #7602 should probably be landed by tomorrow.

@6543
Copy link
Member Author

6543 commented Jul 25, 2019

thx

@stale
Copy link

stale bot commented Sep 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added issue/stale and removed issue/stale labels Sep 23, 2019
@lunny lunny added topic/ui Change the appearance of the Gitea UI issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented labels Sep 30, 2019
@6543
Copy link
Member Author

6543 commented Oct 14, 2019

@silverwind ask for reopen this it you like - i curently dont work on this ...

@6543 6543 closed this as completed Oct 14, 2019
@lafriks lafriks reopened this Oct 15, 2019
@6543
Copy link
Member Author

6543 commented Sep 17, 2020

close this since this is no huge deal and if somebody came with good idears ... he can make it's own issue or pull

@6543 6543 closed this as completed Sep 17, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

No branches or pull requests

4 participants