migration from version 1.8.3 to version 1.9.0 fails #7698

wumpz · 2019-08-01T06:10:28Z

Gitea version (or commit ref): 1.9.0
Operating system: linux / docker
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)
- No
- Not relevant
Log gist:

Description

I have a running 1.8.3 gitea docker server. All works fine. Now I wanted to upgrade to the new version 1.9.0. The server seems to be in a neverending loop initializing itself. All I see in my docker logs is repeatingly endless.

gitea_server_1  | 2019/08/01 05:59:58 ...dules/setting/git.go:83:newGit() [I] Git Version: 2.22.0, Wire Protocol Version 2 Enabled
gitea_server_1  | 2019/08/01 05:59:58 routers/init.go:72:GlobalInit() [T] AppPath: /app/gitea/gitea
gitea_server_1  | 2019/08/01 05:59:58 routers/init.go:73:GlobalInit() [T] AppWorkPath: /app/gitea
gitea_server_1  | 2019/08/01 05:59:58 routers/init.go:74:GlobalInit() [T] Custom path: /data/gitea
gitea_server_1  | 2019/08/01 05:59:58 routers/init.go:75:GlobalInit() [T] Log path: /data/gitea/log
gitea_server_1  | 2019/08/01 05:59:58 ...dules/setting/log.go:226:newLogService() [I] Gitea v1.9.0 built with GNU Make 4.2.1, go1.12.7 : bindata, sqlite, sqlite_unlock_notify

Where should I look for additional informations? Logs?

The text was updated successfully, but these errors were encountered:

wumpz · 2019-08-01T06:11:17Z

By the way, switching back to version 1.8.3 the server starts again like a breeze.

wumpz · 2019-08-01T06:39:49Z

Within the log file, I found this SQL after which a rollback is done.

2019/08/01 06:00:25 ...xorm/xorm/session.go:845:saveLastSQL() [I] [SQL] BEGIN TRANSACTION
2019/08/01 06:00:25 ...xorm/session_find.go:199:noCacheFind() [I] [SQL] SELECT `id`, `uid`, `name`, `sha1`, `token_hash`, `token_salt`, `token_last_eight`, `created_unix`, `updated_unix` FROM `access_token` LIMIT 100
2019/08/01 06:00:25 ...xorm/xorm/session.go:845:saveLastSQL() [I] [SQL] COMMIT
2019/08/01 06:00:25 ...xorm/xorm/session.go:845:saveLastSQL() [I] [SQL] BEGIN TRANSACTION
2019/08/01 06:00:25 .../xorm/session_raw.go:143:queryBytes() [I] [SQL] PRAGMA index_list(`access_token`)
2019/08/01 06:00:25 .../xorm/session_raw.go:143:queryBytes() [I] [SQL] PRAGMA index_info(`IDX_access_token_updated_unix`)
2019/08/01 06:00:25 .../xorm/session_raw.go:143:queryBytes() [I] [SQL] PRAGMA index_info(`IDX_access_token_created_unix`)
2019/08/01 06:00:25 .../xorm/session_raw.go:143:queryBytes() [I] [SQL] PRAGMA index_info(`IDX_access_token_uid`)
2019/08/01 06:00:25 .../xorm/session_raw.go:143:queryBytes() [I] [SQL] SELECT sql FROM sqlite_master WHERE tbl_name='access_token' and type='table'
2019/08/01 06:00:25 .../xorm/session_raw.go:226:Exec() [I] [SQL] CREATE TABLE `new_access_token_new` (`id` INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, `uid` INTEGER NULL, `name` TEXT NULL, `token_hash` TEXT NULL, `token_salt` TEXT NULL, `token_last_eight` TEXT NULL, `created_unix` INTEGER NULL, `updated_unix` INTEGER NULL,
2019/08/01 06:00:25 ...xorm/xorm/session.go:845:saveLastSQL() [I] [SQL] ROLL BACK
2019/08/01 06:00:25 routers/init.go:58:initDBEngine() [I] Backing off for 3 seconds
2019/08/01 06:00:28 routers/init.go:51:initDBEngine() [I] ORM engine initialization attempt #2/10...

zeripath · 2019-08-01T07:01:02Z

I suspect this is an error in droptables - #6849 but why it's not been caught by our migration tests I don't understand.

wumpz · 2019-08-01T08:16:23Z

@zeripath So can I provide additional information to tackle this problem? I really want to upgrade. ;)

phamilton4321 · 2019-08-04T16:18:14Z

Any workaround available? I'm on 1.8.3 with sqlite and can't upgrade to 1.9.0 too because of database errors...

wumpz · 2019-08-04T18:34:41Z

@phamilton4321 as far as I know, the patch is already available and I think it will be there in the next release.

phamilton4321 · 2019-08-04T18:47:26Z

@wumpz okay, thx. I'll stay patient, 1.8.3 Ist more than awesome for me 😁

lonix1 · 2019-08-05T13:43:50Z

I have the same problem when upgrading from 1.7.5

wumpz · 2019-08-06T06:25:44Z

In which version will this be integrated?

lafriks · 2019-08-06T06:34:57Z

1.9.1

phamilton4321 · 2019-08-15T04:50:45Z

Did updating from 1.8.3 to 1.9.1 work for everybody? I'm having the same error as I had while updating to 1.9.0...

wumpz · 2019-08-15T06:04:13Z

Update from 1.8.3 to 1.9.1 worked. Gitea started so far I understand it. The webfront end pops up and shows version 1.9.1. No more error messages within the log.

I am using a docker image of Gitea. Maybe there is still a difference.

phamilton4321 · 2019-08-15T08:56:10Z

Okay, then it might be an issue with my current db. I'm going to check if I can fix it manually.
Thanks anyways

Edit: Created an empty database with 1.9.1 and restored my data from gitea dump sql.
All good now on 1.9.1

dunklesToast · 2019-10-11T14:21:46Z

Upgraded from 1.4.3 to 1.9.3. Having the same issue

2019/10/11 16:19:08 ...xorm/xorm/session.go:845:saveLastSQL() [I] [SQL] COMMIT
2019/10/11 16:19:08 ...xorm/xorm/session.go:845:saveLastSQL() [I] [SQL] BEGIN TRANSACTION
2019/10/11 16:19:08 .../xorm/session_raw.go:143:queryBytes() [I] [SQL] SHOW INDEX FROM issue WHERE column_name IN ('assignee_id')
2019/10/11 16:19:08 .../xorm/session_raw.go:226:Exec() [I] [SQL] DROP INDEX `` ON `issue`
2019/10/11 16:19:08 ...xorm/xorm/session.go:845:saveLastSQL() [I] [SQL] ROLL BACK
2019/10/11 16:19:08 routers/init.go:86:GlobalInit() [F] ORM engine initialization failed: migrate: do migrate: Error 1091: Can't DROP ''; check that column/key exists

guillep2k · 2019-10-11T21:23:55Z

@dunklesToast Please try migrating to intermediate versions (especially before 1.6.0) and let us know which was the latest you could upgrade to. Also, if you could try "SELECT version FROM version", it would help.

zeripath · 2019-10-11T21:54:38Z

@dunklesToast I think I might understand what's going on here!

What database are you using? It's MYSQL right?

zeripath · 2019-10-11T21:55:24Z

I think it's looking for the index, not finding one, but then still trying to remove the index

dunklesToast · 2019-10-11T22:01:20Z

@guillep2k tried that already. With Version 1.5.0 I am getting this error:

Log Mode: File(Info)
2019/10/12 00:00:22 [I] XORM Log Mode: File(Info)
2019/10/12 00:00:22 [I] Cache Service Enabled
2019/10/12 00:00:22 [I] Session Service Enabled
2019/10/12 00:00:22 [I] Migration: Reformat and remove incorrect topics
2019/10/12 00:00:22 [I] This migration could take up to minutes, please be patient.
2019/10/12 00:00:22 [...itea/routers/init.go:60 GlobalInit()] [E] Failed to initialize ORM engine: migrate: do migrate: Sync2: Error 1071: Specified key was too long; max key length is 767 bytes

@zeripath Yep, MySQL. Do you think adding the index manually will fix this?

zeripath · 2019-10-11T22:05:13Z

The causative code is:

gitea/models/migrations/migrations.go

Lines 398 to 423 in ac3613b

    
           case setting.Database.UseMySQL: 
        
           	// Drop indexes on columns first 
        
           	sql := fmt.Sprintf("SHOW INDEX FROM %s WHERE column_name IN ('%s')", tableName, strings.Join(columnNames, "','")) 
        
           	res, err := sess.Query(sql) 
        
           	if err != nil { 
        
           		return err 
        
           	} 
        
           	for _, index := range res { 
        
           		indexName := index["column_name"] 
        
           		_, err := sess.Exec(fmt.Sprintf("DROP INDEX `%s` ON `%s`", indexName, tableName)) 
        
           		if err != nil { 
        
           			return err 
        
           		} 
        
           	} 
        
           	// Now drop the columns 
        
           	cols := "" 
        
           	for _, col := range columnNames { 
        
           		if cols != "" { 
        
           			cols += ", " 
        
           		} 
        
           		cols += "DROP COLUMN `" + col + "`" 
        
           	} 
        
           	if _, err := sess.Exec(fmt.Sprintf("ALTER TABLE `%s` %s", tableName, cols)); err != nil { 
        
           		return fmt.Errorf("Drop table `%s` columns %v: %v", tableName, columnNames, err) 
        
           	}

In particular

gitea/models/migrations/migrations.go

Lines 406 to 407 in ac3613b

    
           indexName := index["column_name"] 
        
           _, err := sess.Exec(fmt.Sprintf("DROP INDEX `%s` ON `%s`", indexName, tableName))

I think I thought it would not return any results if there was no index. Clearly I was wrong.

Simple bug fix add between 406 and 407:

if strings.Trimspace(indexname) == "" {
  continue
}

Probably doesn't need the Trimspace.

Anyone fancy putting a PR up?

guillep2k · 2019-10-11T22:27:17Z

A quick PR? NP. 😁

dunklesToast · 2019-10-11T22:43:41Z

Thanks!
So now I have to wait until this is merged, a new version was compiled and then can I update or is there any hot fix / dirty patch so I can migrate to 1.9?

guillep2k · 2019-10-11T23:53:51Z

@dunklesToast First the PR must be approved. Then one of the owners will assign a milestone for it. Depending on the milestone they may request a backport. And then we must wait until the target release is done.

I don't know how desperate you are 😁, but if you don't want to wait, you could pull the 1.9.4 tag, apply the diff from that PR (it's only a couple of lines), compile and run. That should make it pass the upgrade part. If it works, then you can download and use a vanilla 1.9.4 to stay "standard".

robin-thoni · 2020-02-06T22:11:17Z

What's the status on this? I'm also trying to upgrade from 1.7 and getting the same loop...

jolheiser · 2020-02-06T22:17:44Z

@robin-thoni This issue has (reportedly) been fixed.
Can you please open a new issue with more details? Feel free to link to this one for reference.

zeripath · 2020-02-07T00:29:02Z

Please only migrate to the last point release of a series - so from 1.8.x to 1.9.5 not to 1.9.0. The broken migrations can only be fixed in later point releases - we can't re-release.

lunny added the type/bug label Aug 1, 2019

zeripath mentioned this issue Aug 1, 2019

Fix dropTableColumns sqlite implementation #7710

Merged

zeripath closed this as completed in #7710 Aug 5, 2019

lafriks added this to the 1.9.1 milestone Aug 6, 2019

guillep2k mentioned this issue Oct 11, 2019

Add check for empty set when dropping indexes during migration #8471

Merged

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

migration from version 1.8.3 to version 1.9.0 fails #7698

migration from version 1.8.3 to version 1.9.0 fails #7698

wumpz commented Aug 1, 2019 •

edited

Loading

wumpz commented Aug 1, 2019

wumpz commented Aug 1, 2019

zeripath commented Aug 1, 2019

wumpz commented Aug 1, 2019

phamilton4321 commented Aug 4, 2019

wumpz commented Aug 4, 2019 •

edited

Loading

phamilton4321 commented Aug 4, 2019

lonix1 commented Aug 5, 2019

wumpz commented Aug 6, 2019

lafriks commented Aug 6, 2019

phamilton4321 commented Aug 15, 2019

wumpz commented Aug 15, 2019 •

edited

Loading

phamilton4321 commented Aug 15, 2019 •

edited

Loading

dunklesToast commented Oct 11, 2019 •

edited

Loading

guillep2k commented Oct 11, 2019

zeripath commented Oct 11, 2019 •

edited

Loading

zeripath commented Oct 11, 2019

dunklesToast commented Oct 11, 2019 •

edited

Loading

zeripath commented Oct 11, 2019 •

edited

Loading

guillep2k commented Oct 11, 2019

dunklesToast commented Oct 11, 2019 •

edited

Loading

guillep2k commented Oct 11, 2019

robin-thoni commented Feb 6, 2020 •

edited

Loading

jolheiser commented Feb 6, 2020 •

edited

Loading

zeripath commented Feb 7, 2020

migration from version 1.8.3 to version 1.9.0 fails #7698

migration from version 1.8.3 to version 1.9.0 fails #7698

Comments

wumpz commented Aug 1, 2019 • edited Loading

Description

wumpz commented Aug 1, 2019

wumpz commented Aug 1, 2019

zeripath commented Aug 1, 2019

wumpz commented Aug 1, 2019

phamilton4321 commented Aug 4, 2019

wumpz commented Aug 4, 2019 • edited Loading

phamilton4321 commented Aug 4, 2019

lonix1 commented Aug 5, 2019

wumpz commented Aug 6, 2019

lafriks commented Aug 6, 2019

phamilton4321 commented Aug 15, 2019

wumpz commented Aug 15, 2019 • edited Loading

phamilton4321 commented Aug 15, 2019 • edited Loading

dunklesToast commented Oct 11, 2019 • edited Loading

guillep2k commented Oct 11, 2019

zeripath commented Oct 11, 2019 • edited Loading

zeripath commented Oct 11, 2019

dunklesToast commented Oct 11, 2019 • edited Loading

zeripath commented Oct 11, 2019 • edited Loading

guillep2k commented Oct 11, 2019

dunklesToast commented Oct 11, 2019 • edited Loading

guillep2k commented Oct 11, 2019

robin-thoni commented Feb 6, 2020 • edited Loading

jolheiser commented Feb 6, 2020 • edited Loading

zeripath commented Feb 7, 2020

wumpz commented Aug 1, 2019 •

edited

Loading

wumpz commented Aug 4, 2019 •

edited

Loading

wumpz commented Aug 15, 2019 •

edited

Loading

phamilton4321 commented Aug 15, 2019 •

edited

Loading

dunklesToast commented Oct 11, 2019 •

edited

Loading

zeripath commented Oct 11, 2019 •

edited

Loading

dunklesToast commented Oct 11, 2019 •

edited

Loading

zeripath commented Oct 11, 2019 •

edited

Loading

dunklesToast commented Oct 11, 2019 •

edited

Loading

robin-thoni commented Feb 6, 2020 •

edited

Loading

jolheiser commented Feb 6, 2020 •

edited

Loading