Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit changes diff box does not account for code whitespaces/indentation #8236

Closed
cmarshall108 opened this issue Sep 18, 2019 · 4 comments
Closed
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug

Comments

@cmarshall108
Copy link

The following screenshot is from gitea:

Screen Shot 2019-09-18 at 7 33 11 PM

The following screenshot is from github:

Screen Shot 2019-09-18 at 7 33 02 PM

Both of the repos are the same, and both of the commits above in the screenshots are the same commits. Gitea does not account for the code whitespaces like Github does, i found this a bit confusing and weird. I'm assuming this is not an intended function.

@cmarshall108 cmarshall108 changed the title Commit changes diff box does not account for whitespaces Commit changes diff box does not account for code whitespaces/indentation Sep 18, 2019
@lunny lunny added type/bug topic/ui Change the appearance of the Gitea UI labels Sep 19, 2019
@stale
Copy link

stale bot commented Nov 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Nov 18, 2019
@zeripath
Copy link
Contributor

It's not the whitespace per se it's the word. Github is highlighting the words that change whereas we are highlighting only the minimal change.

I think GitHub is probably doing the correct thing even if it is not highlighting the minimal change

@stale stale bot removed the issue/stale label Nov 18, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Nov 19, 2019
@wxiaoguang
Copy link
Contributor

The diff seems correct on try.gitea.io (although it's different from github, but the spaces are correct)

https://try.gitea.io/wxiaoguang/test/commit/2738b8e18402ed2793cb38e85d81f7da4d77d8d8

image

@wxiaoguang
Copy link
Contributor

ps: if you can not see whitespaces, make sure you are not affected by this : #19309

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

No branches or pull requests

4 participants