Mail notification on commit

[dimmuboy]

• Gitea version (or commit ref): 1.9.3
• Git version: 2.22.1
• Operating system: Arch Linux
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:
  None

Description

I don't know how should it works but I don't get mail notifications about new commits.
I have repo in my watchlist it's starred too.
I'm member of team where repo is.
I have correct mail address and mail server setup (test mail works).
In config file is enabled DEFAULT_EMAIL_NOTIFICATIONS and ENABLE_NOTIFY_MAIL

[bobemoe]

I don't think this is implemented yet. There is discussion (and possibly a fork with this) along with other notification improvements over at #145

[lunny]

We needs a PR to implement that.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[lunny]

I remember one of @guillep2k 's PR will fix this.

[guillep2k]

@lunny Sorry, my PRs were about updating references from commit messages, but commits do not send mail notifications per-se. CommitRepoAction() should handle this, and it creates an action through models.NotifyWatchers, but mails are not generated AFAIK.

[lunny]

Implement NotifyPushCommits will resolve the issue?

[guillep2k]

It looks like most of CommitRepoAction should be moved to notifications. But for a minimal implementation yes, NotifyPushCommits would be enough.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

[guillep2k]

Bump!

[bendem]

On top of that, a visual indicator in the PR's conversation about new commit would also help.

See github including commits in the conversation:

[alam-R]

As a workaround for mailing pushing events, I have created a minimal Java Service to handle a push webhook and map it to mail.
It needs a lot of customization but it can be a workaround for small projects.
For anyone who is interested: https://github.com/alam-R/giteaWebhookMailProxy

Cheers!

[techknowlogick]

Closing this as emails happen on commits (at least to PRs), and they are added to PR conversations.