Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set collaborator permissions with only keyboard #8460

Closed
2 of 7 tasks
Jookia opened this issue Oct 11, 2019 · 6 comments
Closed
2 of 7 tasks

Can't set collaborator permissions with only keyboard #8460

Jookia opened this issue Oct 11, 2019 · 6 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@Jookia
Copy link
Contributor

Jookia commented Oct 11, 2019

Description

When managing collaborators in repository settings, any changes to user permissions made just by using the keyboard to focus the drop down menu and arrows to select an item do not save. I looked at the HTML and saw that the saving only happens onclick, which isn't triggered when using the keyboard.

Because of this you can't set collaborator permissions with only the keyboard. This is a significant roadblock for accessibility.

Screenshots

Bug isn't visible in a screenshot

@lunny lunny added the type/enhancement An improvement of existing functionality label Oct 11, 2019
@stale
Copy link

stale bot commented Dec 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Dec 10, 2019
@zeripath
Copy link
Contributor

Is this still the case?

@stale stale bot removed the issue/stale label Dec 10, 2019
@Jookia
Copy link
Contributor Author

Jookia commented Dec 11, 2019

Yes, I haven't written the rest of the dropdown menu accessibility code as I've been doing other things. I needed to do an audit of the dropdown menus in HTML for a reason I forget- I think so I could test all of them. I'll try having a shot at this sometime this month.

@stale
Copy link

stale bot commented Feb 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 9, 2020
@zeripath zeripath added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Feb 9, 2020
@stale stale bot removed the issue/stale label Feb 9, 2020
@fsologureng
Copy link
Contributor

fsologureng commented Nov 28, 2022

I think this issue is resolved. At least I could added @Jookia as a collaborator in my test repo and set them permissions with just keyboard interaction.

@wxiaoguang
Copy link
Contributor

Fixed by #19861 (comment) and confirmed by Jookia: #19861 (comment)

I will close this issue.

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

5 participants