Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification in PR: too many files changed in this diff #8668

Closed
2 of 7 tasks
taai opened this issue Oct 24, 2019 · 4 comments
Closed
2 of 7 tasks

Notification in PR: too many files changed in this diff #8668

taai opened this issue Oct 24, 2019 · 4 comments

Comments

@taai
Copy link

taai commented Oct 24, 2019

  • Gitea version (or commit ref): 1.10.0+dev-427-gf9aba9ba0
  • Git version: 2.23.0
  • Operating system: Debian
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant

Description

I have a PR with 126 changed files, but I can't review the changes, because only 100 files are being shown in "Files Changed" tab. And at the bottom of the page there is a notification Some files were not shown because too many files changed in this diff
At least I would like to see the list of changed files, if showing the contents of all the files is too much to display...

Also when clicked on button "Show Diff Stats", the list of files was not scrollable, because of CSS .ui.sticky.fixed: position: fixed;.
...

Screenshots

image

...and at the bottom of the page
image

@lunny
Copy link
Member

lunny commented Oct 24, 2019

you can change 100 on app.ini

@taai
Copy link
Author

taai commented Oct 24, 2019

@lunny Thank you, it works! I should have RTFM. 😄 What about the "Show Diff Stats" button and the list of files? Should I better open a new issue?

For anyone who reads this in the future, now I use these settings in my app.ini:

MAX_GIT_DIFF_LINES = 1000
MAX_GIT_DIFF_FILES = 1000

@lunny
Copy link
Member

lunny commented Oct 24, 2019

@taai for that scroll problem I think it has been fixed by #8581 and #8611 . Could you confirm that?

@taai
Copy link
Author

taai commented Oct 24, 2019

@lunny Oh, cool, it is fixed AND there are new features ("Download Patch File" and "Download Diff File") in version 1.11.0+dev-87-g3c63c3ace! 👍

@taai taai closed this as completed Oct 24, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants