Disabling IMPORT_LOCAL_PATHS does not work

[rugk]

see
gogs/gogs#4033 (comment)
gogs/gogs@ae319da

ref #715

---

Is this option already integrated or does Gitea behave in a similar way (just without an option to change the behaviour?)?

[rugk]

As far as I see in 1.0.1 the local server path import is still possible at least for admins. As said, I also want to disable that.

[minecrafter]

In Gitea, the option is called IMPORT_LOCAL_PATHS: https://github.com/go-gitea/gitea/blob/master/conf/app.ini#L181

[rugk]

Even after setting it to false in the UI is is sill shown "or a local server path". (German version)

[minecrafter]

The UI still shows but the app.ini setting does work, even trumping the user's permission.

[lunny]

So this is not an issue?

[rugk]

A wrong UI is IMHO an issue.

[lunny]

Which UI? Could you change this issue's title and put some screenshot here? Or maybe you can fire another issue and close this one?

[rugk]

See @minecrafter replies…

[lunny]

I cannot reproduce it on current master 7eb8daf, please see

gitea/templates/repo/migrate.tmpl

Line 15 in 7eb8daf

<span class="help">{{.i18n.Tr "repo.migrate.clone_address_desc"}}{{if .ContextUser.CanImportLocal}} {{.i18n.Tr "repo.migrate.clone_local_path"}}{{end}}</span>

and

gitea/models/user.go

Line 235 in 7eb8daf

func (u *User) CanImportLocal() bool {

. Please feel free to reopen it.

[rugk]

Ah indeed it is no UI issue, the option does not work in any way. In the config I've set IMPORT_LOCAL_PATHS = false under [security] but as a non-admin user I can still import local repos!

So please reopen. Users cannot do so on GitHub if repo admins close an issue.

Gitea v1.0.1

[Bwko]

@rugk This feature is added to the latest master not to Gitea v1.0.1

[rugk]

Ah, that's the issue, I see…

[tboerger]

Marked as invalid as it correctly works on master.

[rugk]

I can confirm it is fixed, however changing the UI would still be nice. It is not useful to first offer the user to "import local repos" and then say, they do not have the privileges to do so, when they actually (try to) do it.