Skip to content

Support running user-defined hooks through sudo #9093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guillep2k opened this issue Nov 20, 2019 · 1 comment
Open

Support running user-defined hooks through sudo #9093

guillep2k opened this issue Nov 20, 2019 · 1 comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@guillep2k
Copy link
Member

  • Gitea version (or commit ref): 1.10.0

Description

Currently git hooks defined by the users are ran with the same credentials as gitea. It would be more secure if the admin could choose a different set of credentials (e.g. through sudo) to run these scripts. It may even be possible to customize which credentials on a repo-owner basis.

This way admins can ease up a little when giving hook creation permissions.

Additionally, the environment variables should be configurable, to avoid passing info that is not required by that particular owner.

@guillep2k
Copy link
Member Author

From @zeripath:

It's worth being aware that our docker friends who like to use environment variables - as it currently stands the internal ssh and http system leaks that whole environment to the hook commands - openSSH may be configured differently.

@techknowlogick techknowlogick added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

2 participants