Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it OK to apply a patch to 3.2? #111

Closed
hajimehoshi opened this issue Oct 8, 2018 · 1 comment
Closed

Is it OK to apply a patch to 3.2? #111

hajimehoshi opened this issue Oct 8, 2018 · 1 comment

Comments

@hajimehoshi
Copy link
Member

Hi,

There is a relatively serious bug in GLFW 3.2 that key events on X11 are not fired correctly (glfw/glfw#747, also discussed at hajimehoshi/ebiten#648). This is fixed in GLFW 3.3 and we confirmed that the same patch (glfw/glfw@4ff66a7) works on GLFW 3.2. However, GLFW 3.3 is still beta and no one knows when it will be released.

My question is, would it be acceptable to apply that patch to go-gl's GLFW 3.2? I'm not sure the policy of go-gl GLFW and if we should keep this a simple wrapper of GLFW as it is, perhaps we should NOT apply the patch. If it is fine, I'd like to send the PR as soon as possible.
@hajimehoshi hajimehoshi mentioned this issue Oct 8, 2018
Closed
@hajimehoshi
Copy link
Member Author

Oops, I should have posted to glfw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hajimehoshi