Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate moving to grpc #16

Open
dgryski opened this issue Nov 21, 2015 · 4 comments
Open

Investigate moving to grpc #16

dgryski opened this issue Nov 21, 2015 · 4 comments
Milestone

Comments

@dgryski
Copy link
Member

dgryski commented Nov 21, 2015

No description provided.

@Dieterbe
Copy link

What are the benefits ?

@dgryski
Copy link
Member Author

dgryski commented Aug 28, 2016

All the connections are pipelined over a single TCP connection, which means we don't have (literally) thousands of network connections to every server across a large cluster topology. That's the primary benefit I'd like. We'd probably also get a small improvement from the switch to protobuf v3. (Small in this case -- fewer pointers because v3 has values instead of making everything *Int32, etc.)

I'd probably add context and x/net/trace support while I was at it.

@nnuss
Copy link
Collaborator

nnuss commented Aug 28, 2016

+1

@dgryski
Copy link
Member Author

dgryski commented Mar 17, 2017

Step 1 of moving to protobuf v3 is done.

@Civil Civil added this to the 0.80 milestone Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants