Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1109

Closed
sagikazarmark opened this issue Jun 18, 2021 · 6 comments
Closed

Update dependencies #1109

sagikazarmark opened this issue Jun 18, 2021 · 6 comments
Assignees
Milestone

Comments

@sagikazarmark
Copy link
Contributor

Let's update the dependencies of this project to use latest versions.

I'd prefer finishing #1100 first, because it already changes dependencies considerably.

@ChrisHines
Copy link
Member

#1105 includes a commit where I made a pass at that. Of note, I got some panics it the metrics/cloudwatch2 tests after upgrading. Also I believe there are breaking API changes in the newest versions of those dependencies someone should take a look at.

@sagikazarmark
Copy link
Contributor Author

Thanks, I'll take a look at that.

We should consider upgrading to the v2 SDK for AWS. It's not a giant module anymore for every service.

@sagikazarmark sagikazarmark added this to the v0.11.0 milestone Jun 19, 2021
@ChrisHines
Copy link
Member

We should consider upgrading to the v2 SDK for AWS. It's not a giant module anymore for every service.

Yeah, I noticed that, but didn't want to take on the effort of figuring out how to use the new API. I agree it is probably a good idea for someone to do, though.

@sagikazarmark
Copy link
Contributor Author

I'm gonna take a look at it.

@sagikazarmark
Copy link
Contributor Author

PRs sent. I left the "old" AWS SDK in place for now. I couldn't tell the difference between cloudwatch and cloudwatch2. If the only difference is the AWS SDK version, we could just deprecate the old one.

@sagikazarmark
Copy link
Contributor Author

Dependencies are updated. We can run go get -u one more time before tagging the final release. I'm closing this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants