Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandoned packages #1127

Closed
sagikazarmark opened this issue Jun 30, 2021 · 8 comments
Closed

Abandoned packages #1127

sagikazarmark opened this issue Jun 30, 2021 · 8 comments
Milestone

Comments

@sagikazarmark
Copy link
Contributor

There are a couple packages that seem to be abandoned and outdated (ie. dependencies are old, no go.mod, etc).

These are:

If there is no answer, I propose we fork them, make the necessary updates and use the forks as drop-in replacements. Before we do that, though, we should consider whether we want to keep these in the core in the first place. It might not worth the hassle if they get moved out of the core. So this issue is a conversation starter.

Related #843

@peterbourgon
Copy link
Member

I'd much rather drop them altogether.

@sagikazarmark
Copy link
Contributor Author

Works for me, although I already got them both to update to modules and release versions.

@bnevis-i
Copy link

Additionally, aws-sdk-go@v1.38.68 is introducing transitive vulnerabilities into this package (CVE-2020-9283). Bringing the whole go.mod up to date in general would be a good idea.

@peterbourgon
Copy link
Member

We did that like two weeks ago. Ugh. What a waste of time.

@bnevis-i
Copy link

Actually, I take that back. aws-sdk doesn't have direct dependency on the broken library. Egg on my face :-(

@peterbourgon
Copy link
Member

Not at all, best news I've heard today.

@sagikazarmark
Copy link
Contributor Author

@peterbourgon I'd suggest updating these two packages and at the same time deprecating them in the next release.

Are there any other packages that we should deprecate? Should we start planning for #843?

@sagikazarmark
Copy link
Contributor Author

Closing as both libraries have been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants