Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT: Removing opinionated usage of Claims #490

Closed
cam-stitt opened this issue Mar 8, 2017 · 3 comments
Closed

JWT: Removing opinionated usage of Claims #490

cam-stitt opened this issue Mar 8, 2017 · 3 comments

Comments

@cam-stitt
Copy link
Contributor

I created a PR to introduce support for additional claim objects in #488. After doing some thinking I came to a conclusion that some more work needs to be done on the jwt package.

  • Remove the ambiguous Claims object
  • Enforce the Sign/Parse methods to accept a jwt.Claims parameter

The current implementation leans towards only using MapClaims and I'm not sure what value the go-kit Claims object is providing.

@vgheri
Copy link

vgheri commented Mar 8, 2017

Agree, I'm not using the go-kit jwt middleware for this exact same reason.

@cam-stitt
Copy link
Contributor Author

I ended up just modifying #488 to completely remove the ambiguous Claims type.

The other major change is that this is a backwards incompatible change.

@basvanbeek
Copy link
Member

#488 has been merged and closes this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants