Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.9.0 introduced breaking API change in metrics package #890

Closed
mjneil opened this issue Jul 2, 2019 · 3 comments
Closed

v0.9.0 introduced breaking API change in metrics package #890

mjneil opened this issue Jul 2, 2019 · 3 comments

Comments

@mjneil
Copy link

mjneil commented Jul 2, 2019

#837 included in the 0.9.0 release introduced breaking API changes for the metrics package, but this wasn't documented in the changelog in any way. Could you please update the release log to highlight this. I know its v0 so semver rules aren't really being broken, but it should be documented so users aren't trying to figure out why their builds a breaking.
@peterbourgon
Copy link
Member

Apologies for that.

@peterbourgon
Copy link
Member

I've updated the release page with a big disclaimer. Again, very sorry.

@mjneil
Copy link
Author

mjneil commented Jul 2, 2019

@peterbourgon Thanks for the quick update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterbourgon @mjneil