-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SD:Consul - Index handling is incorrect per consul docs #997
Labels
Milestone
Comments
I have a proposed fix for these two errors in my local repo. |
Happy to take a PR. |
Fixed in #999 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The loop where index handling is incorrect.
Consul Docs
https://www.consul.io/api-docs/features/blocking#implementation-details
Index goes backwards
In rare cases, the index can be returned that is before the last index. In this case, the system can basically miss out on events for either a very long time or forever. This can be pretty damaging if you depend on the consistency of the SD value & the value does not appropriately update.
Index returned is zero
In rare cases the returned index can be zero. In this case the code should backoff and try again to avoid a tight loop.
The text was updated successfully, but these errors were encountered: