Skip to content

Commit 06d50d1

Browse files
authored
Revert #499: Mark public Start function as deprecated (#508)
* Revert "chore: add comment to `Start` function to inform about possible instability when called (#499)" This reverts commit f09ee91. * chore: add warning to `Start` comment to inform about possible race conditions
1 parent 2260012 commit 06d50d1

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

conn.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -266,10 +266,9 @@ func NewConn(conn net.Conn, isTLS bool) *Conn {
266266
}
267267

268268
// Start initialises goroutines to read replies and process messages.
269+
// Warning: Calling this function in addition to Dial or DialURL
270+
// may cause race conditions.
269271
//
270-
// Deprecated: It is usually not necessary to call this function
271-
// manually. It is public for compatibility reasons and may
272-
// cause a race condition when processing messages.
273272
// See: https://github.com/go-ldap/ldap/issues/356
274273
func (l *Conn) Start() {
275274
go l.reader()

v3/conn.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -266,10 +266,9 @@ func NewConn(conn net.Conn, isTLS bool) *Conn {
266266
}
267267

268268
// Start initialises goroutines to read replies and process messages.
269+
// Warning: Calling this function in addition to Dial or DialURL
270+
// may cause race conditions.
269271
//
270-
// Deprecated: It is usually not necessary to call this function
271-
// manually. It is public for compatibility reasons and may
272-
// cause a race condition when processing messages.
273272
// See: https://github.com/go-ldap/ldap/issues/356
274273
func (l *Conn) Start() {
275274
go l.reader()

0 commit comments

Comments
 (0)