Reformat en locale time formatting to fix issue for 12:00 AM formatting #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* FmtTimeShort, FmtTimeMedium, FmtTimeLong and FmtTimeFull all formatted hours using 24 hour time * Fix reformats hour to adhere to 12 hour format and align with CLDR spec
|
@deankarn I had a go at fixing this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This issue addresses a bug which was raised in #41 . Please see the issue comments for further understanding of the conversation around this issue.
TLDR:
According to the CLDR specification the 'en' locale should be formatting the value for 12:00 AM as
12:00 AMand not00:00 AMChanges:
Excluded:
In addition to this, I discovered the same issue exists for a large number of the en locales, any locale which should be formatting hours as the patter
has defined by the CLDR spec. I excluded these, due to a large number of unit tests being commented out for those locales. Given I am not aware of the context as to why they are commented out, I didn't want to touch those.I have created a follow up issue to address this: #45
fixes #41