Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lost repsonse and no error return #59

Closed
lrita opened this issue Mar 10, 2017 · 4 comments
Closed

Lost repsonse and no error return #59

lrita opened this issue Mar 10, 2017 · 4 comments
Assignees
@jeevatkm
Labels
enhancement
Milestone
v0.11 Milestone

Comments

@lrita
Copy link
Contributor

lrita commented Mar 10, 2017

Someone api will cost N ms.

If we SetTimeout M ms (N< M < 2N) to Client and we call this api twice, the server side will receive three request and send three response.

In client side, user only see 2 api call but 3 api call be sent actually.

This issue will be duplicated in go 1.7.3, here is the code.

I found a bad implement of SetTimeout and fix it.
@lrita lrita mentioned this issue Mar 10, 2017
Merged
@jeevatkm jeevatkm self-assigned this Mar 10, 2017
@jeevatkm jeevatkm added this to the v0.11 Milestone milestone Mar 10, 2017
@jeevatkm
Copy link
Member

@lrita Thanks for your PR, I have added a comment. Please have a look.

@lrita
Copy link
Contributor Author

lrita commented Mar 11, 2017

I have fixed the build errors in golang 1.2.

@jeevatkm
Copy link
Member

Thanks @lrita.

@jeevatkm
Copy link
Member

PR #60 Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeevatkm jeevatkm

Labels
enhancement
Milestone
v0.11 Milestone
Development

No branches or pull requests
2 participants
@jeevatkm @lrita