Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: use vfs instead os filesystem #15

Open
KaymeKaydex opened this issue Nov 16, 2023 · 3 comments
Open

feature: use vfs instead os filesystem #15

KaymeKaydex opened this issue Nov 16, 2023 · 3 comments

Comments

@KaymeKaydex
Copy link

KaymeKaydex commented Nov 16, 2023

https://github.com/blang/vfs

Currently the library can only use system files, but I would like to be able to use vfs too

@Monirzadeh
Copy link

Monirzadeh commented Nov 16, 2023

Pull request welcome
Sidenote:
@KaymeKaydex as i see this library not maintain actively do you know any better alternative?

@fmartingr
Copy link
Member

fmartingr commented Nov 18, 2023

What's the benefit of using this vs over using io.fs?

Edit: This one seems more maintained: https://github.com/C2FO/vfs or https://github.com/spf13/afero

@fmartingr
Copy link
Member

Ok, now that I'm using io.fs more in Shiori doing some tests and refactor, I see the benefit of using a third party filesystem implementation.

A TLDR is: io.fs does not implement writer interfaces. I get to the point where I could test/implement all method that read from a filesystem, but the moment I needed to refactor the write I was stuck having to implement my own.

I'm not saying this would be beneficial for go-epub itself, just answering my own question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants