Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support GitHub oauth2 login #154

Merged
merged 2 commits into from
Jul 22, 2023
Merged

✨ Support GitHub oauth2 login #154

merged 2 commits into from
Jul 22, 2023

Conversation

tosone
Copy link
Contributor

@tosone tosone commented Jul 22, 2023

No description provided.

@tosone tosone added this to the Release v0.1.0 milestone Jul 22, 2023
@tosone tosone self-assigned this Jul 22, 2023
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Patch coverage: 37.34% and project coverage change: -0.78 ⚠️

Comparison is base (6ff70c9) 61.64% compared to head (ff3e622) 60.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
- Coverage   61.64%   60.87%   -0.78%     
==========================================
  Files          97       99       +2     
  Lines        4910     5050     +140     
==========================================
+ Hits         3027     3074      +47     
- Misses       1652     1737      +85     
- Partials      231      239       +8     
Flag Coverage Δ
unit-test-mysql 60.87% <37.34%> (-0.78%) ⬇️
unit-test-postgresql 60.87% <37.34%> (-0.78%) ⬇️
unit-test-sqlite3 60.87% <37.34%> (-0.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/configs/deploy.go 25.00% <ø> (ø)
pkg/dal/dao/audit.go 0.00% <0.00%> (ø)
pkg/dal/dao/user.go 88.88% <0.00%> (-11.12%) ⬇️
pkg/handlers/users/users_login.go 100.00% <ø> (ø)
pkg/handlers/users/users_logout.go 100.00% <ø> (ø)
pkg/handlers/users/users_self.go 0.00% <0.00%> (ø)
pkg/handlers/users/users_signup.go 100.00% <ø> (ø)
pkg/validators/validators.go 80.48% <20.00%> (-8.41%) ⬇️
pkg/dal/dao/repository.go 48.57% <25.00%> (ø)
pkg/handlers/namespaces/handler.go 73.91% <40.00%> (-4.14%) ⬇️
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tosone tosone enabled auto-merge July 22, 2023 03:36
@tosone tosone disabled auto-merge July 22, 2023 04:48
@tosone tosone enabled auto-merge July 22, 2023 04:48
@tosone tosone force-pushed the dev branch 3 times, most recently from 848a9af to a4cc64a Compare July 22, 2023 07:11
@tosone tosone added this pull request to the merge queue Jul 22, 2023
Merged via the queue into main with commit 8080e13 Jul 22, 2023
@tosone tosone deleted the dev branch July 22, 2023 07:37
@tosone
Copy link
Contributor Author

tosone commented Jul 22, 2023

#145

@tosone tosone linked an issue Jul 22, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support login with GitHub with oauth2.
1 participant