Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix user create or update failed #325

Merged
merged 1 commit into from
Mar 7, 2024
Merged

🐛 Fix user create or update failed #325

merged 1 commit into from
Mar 7, 2024

Conversation

tosone
Copy link
Contributor

@tosone tosone commented Mar 7, 2024

ref: #324

@tosone tosone added the bug Something isn't working label Mar 7, 2024
@tosone tosone added this to the Release v1.2.0 milestone Mar 7, 2024
@tosone tosone self-assigned this Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 22.80%. Comparing base (fb0ce2e) to head (01a854a).

Files Patch % Lines
pkg/dal/dao/mocks/user.go 0.00% 16 Missing ⚠️
pkg/dal/dao/user.go 0.00% 11 Missing ⚠️
pkg/handlers/users/users_post.go 0.00% 7 Missing ⚠️
pkg/handlers/users/users_put.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
- Coverage   23.39%   22.80%   -0.59%     
==========================================
  Files         275      273       -2     
  Lines       19020    18707     -313     
==========================================
- Hits         4449     4266     -183     
+ Misses      14150    14053      -97     
+ Partials      421      388      -33     
Flag Coverage Δ
unit-test-mysql 22.80% <0.00%> (-0.59%) ⬇️
unit-test-postgresql 22.80% <0.00%> (-0.59%) ⬇️
unit-test-sqlite3 22.80% <0.00%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tosone tosone enabled auto-merge March 7, 2024 14:29
@tosone tosone added this pull request to the merge queue Mar 7, 2024
Merged via the queue into go-sigma:main with commit ee75d7c Mar 7, 2024
10 of 11 checks passed
@tosone tosone deleted the dev branch March 7, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant