Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow equal time-stamps to be considered up-to-date #49

Closed
smyrman opened this issue Jul 12, 2017 · 0 comments · Fixed by #50
Closed

Allow equal time-stamps to be considered up-to-date #49

smyrman opened this issue Jul 12, 2017 · 0 comments · Fixed by #50

Comments

@smyrman
Copy link
Contributor

smyrman commented Jul 12, 2017

Proposal

A task should be considered up-to-date if the newest timestamp for sources is exactly equal to the oldest timestamp from generates.

Background

On Mac, the default filesystem, HFS, only supports second precession for file modification timestamps. Windows NTFS (in theory) supports 100-nanosecond interval precession, while ext4 on Linux rely on cached timestamps from the kernel which in most cases would at least be about 100 ms apart.

Especially on HFS, this can create some hard-to-debug issues where tasks some times are considered up-to-date, and sometimes not.

While writing the tests for #47, it took me a while to figure out why my test worked (sometimes) when I run task manually in "testdata/generates", but never when I run it from task_test.go. For real-life use-cases, this would help with getting a more consistent behavior when we have task-output from one task used as input in the next (short-running) task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants