Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow setting secret as key/value to vela volume #2

Merged
merged 2 commits into from
Jun 29, 2020
Merged

feat: allow setting secret as key/value to vela volume #2

merged 2 commits into from
Jun 29, 2020

Conversation

kneal
Copy link
Collaborator

@kneal kneal commented Jun 17, 2020 •
edited
Loading

Package updates:

  • main now contains a read action to take secrets from a Vault instance and set those secrets within Vela's volume
  • config new concept to store the plugin actions and configuration
  • read new concept to read a Vault and set secret on the volume
  • vault package for integrating with Vault instances
    • Only supports token auth but will be expanding auth types

Related work:

@kneal kneal added the feature Indicates a new feature label Jun 17, 2020
@kneal kneal self-assigned this Jun 17, 2020
@kneal kneal changed the title feat: allow setting secret as key/value to environment feat: allow setting secret as key/value to vela volume Jun 23, 2020
@kneal kneal marked this pull request as ready for review June 23, 2020 15:24
jbrockopp
jbrockopp approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wass3r wass3r merged commit 4f157b4 into master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockopp jbrockopp jbrockopp approved these changes

@wass3r wass3r wass3r approved these changes

Assignees

@kneal kneal

Labels
feature Indicates a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kneal @wass3r @jbrockopp