Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add github actions workflows #3

Merged
merged 7 commits into from
Jul 21, 2020
Merged

feat: add github actions workflows #3

merged 7 commits into from
Jul 21, 2020

Conversation

kneal
Copy link
Collaborator

@kneal kneal commented Jun 23, 2020

This PR contains (Pulled files from existing projects):

  • Standard CI pipeline workflows
  • Changelog templates required for changelog workflow
  • Add standard GolangCI lint rules
  • Add standard CodeCov file

Note: This build will fail because it does not have the make file that is in the other PR

@kneal kneal added the feature Indicates a new feature label Jun 23, 2020
@kneal kneal self-assigned this Jun 23, 2020
.chglog/config.yml Outdated Show resolved Hide resolved
jbrockopp
jbrockopp previously approved these changes Jun 24, 2020
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix build error :D

@kneal
Copy link
Collaborator Author

kneal commented Jun 29, 2020

@wass3r it was in the other PR:
https://github.com/go-vela/secret-vault/pull/2/files#diff-b67911656ef5d18c4ae36cb6741b7965R5

I'm trying to figure out how to update this branch. I don't see it in the PR box for "update branch"

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@4f157b4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   27.81%           
=========================================
  Files             ?        7           
  Lines             ?      151           
  Branches          ?        0           
=========================================
  Hits              ?       42           
  Misses            ?      101           
  Partials          ?        8           

@kneal
Copy link
Collaborator Author

kneal commented Jun 29, 2020

@wass3r think we got it now

Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kneal
Copy link
Collaborator Author

kneal commented Jul 8, 2020

@wass3r this look good now?

@wass3r wass3r merged commit 59f86fc into master Jul 21, 2020
@wass3r wass3r deleted the ci/actions branch July 21, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants