v3: dumps indenting not coherent with v2

[sylr]

The way v3 indents dumps by default is different from v2 and I think it shouldn't be:

• default indenting is now 4 spaces instead of 2
• list items are now shifted right instead of being vertically aligned with the key

a: Easy! v2
b:
  c: 2
  d:
  - 3
  - 4

a: Easy! v3
b:
    c: 2
    d:
        - 3
        - 4

I know it won't matter but I personally prefer the looks of the first dump.

Also I've seen this change break tests that rely on yaml string equality.

[laverya]

I've also seen this break unit tests.

[niemeyer]

Yes, in v3 we've fixed the indentation so that each level is coherently aligned across all elements and nesting levels. Note in your example how the second output is perfectly aligned according to its depth, while the first is not.

Tests expecting an exact format will indeed break. That's why this was done between v2 and v3 and not inside the release.

[bai]

Given how low level this lib is, this looks like a major breaking change for many people. If you really insist on having it in place, maybe it'd make sense to have it as part of v4? Do you think you could re-consider this change as part of v3? 🙏

For example, kustomize and kpt are all guaranteeing consistent formatting when managing kubernetes manifests for GitOps et al. This is going to cause a lot of changes in Kubernetes manifests ecosystem out of the blue.