Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it ok to GetByString(s).Get().(string)? #19

Open
marselester opened this issue Oct 20, 2023 · 0 comments
Open

Is it ok to GetByString(s).Get().(string)? #19

marselester opened this issue Oct 20, 2023 · 0 comments

Comments

@marselester
Copy link

Could you please confirm whether Thanos approach to string interning intern.GetByString(s).Get().(string) is a valid use of GetByString or a package user must use *Value like in netip?

type Addr struct {
    z *intern.Value
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant