Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DalamudPackager doesn't generate the JSON for you #8

Open
philpax opened this issue Aug 29, 2022 · 0 comments
Open

DalamudPackager doesn't generate the JSON for you #8

philpax opened this issue Aug 29, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@philpax
Copy link

philpax commented Aug 29, 2022

DIP17 moves the contents of the JSON into the DalamudPlugin block;
https://github.com/goatcorp/DIPs/blob/main/text/17-automated-build-and-submit-pipeline.md#guide-level-explanation

The packager should generate the JSON for you when run by Plogon, but this doesn't appear to be the case: https://github.com/goatcorp/DalamudPluginsD17/runs/8076407334?check_suite_focus=true#step:9:381
@philpax philpax added the bug Something isn't working label Aug 29, 2022
@philpax philpax mentioned this issue Sep 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philpax