Throw when passing undefined to unlisten

goatslacker · Jun 6, 2015 · 4998c6a · 4998c6a
1 parent c9462ba
commit 4998c6a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/alt/store/AltStore.js b/src/alt/store/AltStore.js
@@ -98,6 +98,7 @@ class AltStore {
  }
 
  unlisten(cb) {
+ if (!cb) throw new TypeError('Unlisten must receive a function')
  this[Sym.LIFECYCLE].emit('unlisten')
  this[EE].removeListener('change', cb)
  }

diff --git a/test/index.js b/test/index.js
@@ -579,6 +579,10 @@ const tests = {
 
  assert(myStore.getState().name === 'badger', 'new store state present')
  assert.ok(mooseChecker.calledOnce)
+
+ assert.throws(() => {
+ myStore.unlisten()
+ })
  },
 
  'unlisten lifecycle hook'() {
@@ -591,7 +595,7 @@ const tests = {
  const store = alt.createStore(XStore)
 
  // unlisten directly
- store.listen()()
+ store.listen(function () { })()
 
  assert.ok(unlistener.calledOnce, 'unlisten lifecycle hook called')
  },