Cache final stores so only one is returned per alt instance

goatslacker · Apr 25, 2015 · 838d8cb · 838d8cb
1 parent 0f6e3e0
commit 838d8cb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/utils/makeFinalStore.js b/src/utils/makeFinalStore.js
@@ -35,5 +35,7 @@ function FinalStore() {
 }
 
 export default function makeFinalStore(alt) {
-  return alt.createUnsavedStore(FinalStore)
+  return alt.FinalStore
+    ? alt.FinalStore
+    : (alt.FinalStore = alt.createUnsavedStore(FinalStore))
 }
diff --git a/test/final-store.js b/test/final-store.js
@@ -4,6 +4,7 @@ import { assert } from 'chai'
 import sinon from 'sinon'
 
 const alt = new Alt()
+const FinalStore = makeFinalStore(alt)
 
 export default {
   'FinalStore': {
@@ -69,5 +70,10 @@ export default {
       assert.ok(stateListen.calledOnce, 'final store called once')
       assert(stateListen.args[0][0].payload.data === 27, 'the payload was received')
     },
+
+    'making another final store returns the right store'() {
+      const store = makeFinalStore(alt)
+      assert(store === FinalStore)
+    },
   }
 }