Fix regression for not setting state if reduce returns undefined

goatslacker · Oct 21, 2015 · cebd8e8 · cebd8e8
1 parent 9dd8e09
commit cebd8e8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/alt/store/AltStore.js b/src/alt/store/AltStore.js
@@ -71,7 +71,8 @@ class AltStore {
 
       if (model.reduce) {
         handleDispatch(() => {
-          this.state = model.reduce(this.state, payload)
+          const value = model.reduce(this.state, payload)
+          if (value !== undefined) this.state = value
         }, payload)
         if (!this.preventDefault) this.emitChange()
       }

diff --git a/test/functional-test.js b/test/functional-test.js
@@ -107,13 +107,15 @@ export default {
         state: { x: 0 },
 
         reduce(state) {
+          if (state.x >= 3) return
           return { x: state.x + 1 }
         }
       })
 
       actions.fire()
       actions.fire()
       actions.fire()
+      actions.fire()
 
       assert(store.getState().x === 3, 'counter was incremented')
     },