Make alt FSA compliant

Author: goatslacker

src/alt/index.js

@@ -31,12 +31,7 @@ class Alt {
         return utils.dispatch(id, action, data, this)
       }
 
-      return this.dispatcher.dispatch({
-        id,
-        action,
-        data,
-        details,
-      })
+      return this.dispatcher.dispatch(utils.fsa(id, action, data, details))
     })
   }
 

src/alt/utils/AltUtils.js

@@ -46,6 +46,22 @@ export function dispatchIdentity(x, ...a) {
   this.dispatch(a.length ? [x].concat(a) : x)
 }
 
+export function fsa(id, type, payload, details) {
+  return {
+    type,
+    payload,
+    meta: {
+      dispatchId: id,
+      ...details,
+    },
+
+    id,
+    action: type,
+    data: payload,
+    details,
+  }
+}
+
 export function dispatch(id, actionObj, payload, alt) {
   const data = actionObj.dispatch(payload)
   if (data === undefined) return null
@@ -59,12 +75,8 @@ export function dispatch(id, actionObj, payload, alt) {
 
   if (fn.isFunction(data)) return data(dispatchLater, alt)
 
-  return alt.dispatcher.dispatch({
-    id,
-    action: type,
-    data,
-    details,
-  })
+    // XXX standardize this
+  return alt.dispatcher.dispatch(fsa(id, type, data, details))
 }
 
 /* istanbul ignore next */

test/index.js

@@ -1482,6 +1482,21 @@ const tests = {
     const store = alt.createStore(Store)
     alt.dispatch(action)
   },
+
+  'is fsa'(done) {
+    alt.dispatcher.register((x) => {
+      assert.isDefined(x.type, 'there is a type')
+      assert.isDefined(x.payload, 'there is a payload')
+      assert.isDefined(x.meta, 'meta exists')
+      assert.isString(x.meta.dispatchId, 'meta contains a unique dispatch id')
+
+      assert(x.payload === 'Jane', 'the payload is correct')
+
+      done()
+    })
+
+    myActions.updateName('Jane')
+  },
 }
 
 export default tests